Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 502028: Streamline the calling convention of the call ICs by passing the... (Closed)

Created:
11 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Committed: http://code.google.com/p/v8/source/detail?r=3484

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -158 lines) Patch
M src/arm/fast-codegen-arm.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/fast-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +25 lines, -22 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 7 chunks +17 lines, -22 lines 0 comments Download
M src/ia32/ic-ia32.cc View 5 chunks +40 lines, -27 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 18 chunks +55 lines, -32 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M src/ic.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ic.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/x64/ic-x64.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years ago (2009-12-16 10:41:05 UTC) #1
Kasper Lund
11 years ago (2009-12-17 08:24:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698