Add "open as window" menu item to NTP app menu.

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index f175ecbd8fa1a5229fd7ee4bffead0259d53a244..23a4c677b5a515c1da2911655b5247e26ba686f7 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -496,8 +496,13 @@ TabContents* Browser::OpenApplication(Profile* profile,
                                       const std::string& app_id,
                                       TabContents* existing_tab) {
   ExtensionsService* extensions_service = profile->GetExtensionsService();
-  if (!extensions_service->is_ready())
+  if (!extensions_service->is_ready()) {

[Aaron Boodman, 2010/11/17 06:12:47]

Again here, I think we can take this code out now.

[Sam Kerner (Chrome), 2010/11/18 03:53:36]

Done.

+    // The extensions service should load extensions as part of
+    // profile construction.  The fact that we have a profile should
+    // imply that the extensions service is ready.
+    NOTREACHED();
     return NULL;
+  }
 
   // If the extension with |app_id| could't be found, most likely because it
   // was uninstalled.
@@ -520,9 +525,11 @@ TabContents* Browser::OpenApplication(
 
   UMA_HISTOGRAM_ENUMERATION("Extensions.AppLaunchContainer", container, 100);
 
-  // The app is not yet open.  Load it.
   switch (container) {
     case extension_misc::LAUNCH_WINDOW:
+      tab = Browser::OpenApplicationWindow(profile,
+                                           extension->GetFullLaunchURL());
+      break;
     case extension_misc::LAUNCH_PANEL:
       tab = Browser::OpenApplicationWindow(profile, extension, container,
                                            GURL());
@@ -585,7 +592,7 @@ TabContents* Browser::OpenApplicationWindow(
 }
 
 // static
-TabContents* Browser::OpenApplicationWindow(Profile* profile, GURL& url) {
+TabContents* Browser::OpenApplicationWindow(Profile* profile, const GURL& url) {
   return OpenApplicationWindow(profile, NULL, extension_misc::LAUNCH_WINDOW,
                                url);
 }