Add "open as window" menu item to NTP app menu.

chrome/browser/ui/browser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 478 matching lines @@
 }
 
 // static
 // TODO(erikkay): There are multiple reasons why this could fail.  Should
 // this function return an error reason as well so that callers can show
 // reasonable errors?
 TabContents* Browser::OpenApplication(Profile* profile,
                                       const std::string& app_id,
                                       TabContents* existing_tab) {
   ExtensionsService* extensions_service = profile->GetExtensionsService();
-  if (!extensions_service->is_ready())
+  if (!extensions_service->is_ready()) {

[Aaron Boodman, 2010/11/17 06:12:47]

Again here, I think we can take this code out now.

[Sam Kerner (Chrome), 2010/11/18 03:53:36]

Done.

+    // The extensions service should load extensions as part of
+    // profile construction.  The fact that we have a profile should
+    // imply that the extensions service is ready.
+    NOTREACHED();
     return NULL;
+  }
 
   // If the extension with |app_id| could't be found, most likely because it
   // was uninstalled.
   const Extension* extension =
       extensions_service->GetExtensionById(app_id, false);
   if (!extension)
     return NULL;
 
   return OpenApplication(profile, extension, extension->launch_container(),
                          existing_tab);
 }
 
 // static
 TabContents* Browser::OpenApplication(
     Profile* profile,
     const Extension* extension,
     extension_misc::LaunchContainer container,
     TabContents* existing_tab) {
   TabContents* tab = NULL;
 
   UMA_HISTOGRAM_ENUMERATION("Extensions.AppLaunchContainer", container, 100);
 
-  // The app is not yet open.  Load it.
   switch (container) {
     case extension_misc::LAUNCH_WINDOW:
+      tab = Browser::OpenApplicationWindow(profile,
+                                           extension->GetFullLaunchURL());
+      break;
     case extension_misc::LAUNCH_PANEL:
       tab = Browser::OpenApplicationWindow(profile, extension, container,
                                            GURL());
       break;
     case extension_misc::LAUNCH_TAB: {
       tab = Browser::OpenApplicationTab(profile, extension, existing_tab);
       break;
     }
     default:
       NOTREACHED();
@@ skipping 42 matching lines @@
     // OnDidGetApplicationInfo, which calls
     // web_app::UpdateShortcutForTabContents when it sees UPDATE_SHORTCUT as
     // pending web app action.
     browser->pending_web_app_action_ = UPDATE_SHORTCUT;
   }
 
   return contents;
 }
 
 // static
-TabContents* Browser::OpenApplicationWindow(Profile* profile, GURL& url) {
+TabContents* Browser::OpenApplicationWindow(Profile* profile, const GURL& url) {
   return OpenApplicationWindow(profile, NULL, extension_misc::LAUNCH_WINDOW,
                                url);
 }
 
 // static
 TabContents* Browser::OpenApplicationTab(Profile* profile,
                                          const Extension* extension,
                                          TabContents* existing_tab) {
   Browser* browser = BrowserList::GetLastActiveWithProfile(profile);
   TabContents* contents = NULL;
@@ skipping 3494 matching lines @@
   NOTREACHED();
   return false;
 }
 
 void Browser::CreateInstantIfNecessary() {
   if (type() == TYPE_NORMAL && InstantController::IsEnabled(profile()) &&
       !profile()->IsOffTheRecord()) {
     instant_.reset(new InstantController(profile_, this));
   }
 }