Fixes a crash when entering a negative index with chrome.tabs.move ....

chrome/test/data/extensions/api_test/tabs/basics/move.html

Index: chrome/test/data/extensions/api_test/tabs/basics/move.html
===================================================================
--- chrome/test/data/extensions/api_test/tabs/basics/move.html	(revision 65777)
+++ chrome/test/data/extensions/api_test/tabs/basics/move.html	(working copy)
@@ -69,6 +69,16 @@
         }));
       }));
     }));
+
+    // Check that the browser doesn't segfault on a negative index

[Aaron Boodman, 2010/11/16 20:21:28]

Nit: add a period to the end of this sentence. Also, add a reference to the bug
here that we fixed so that people can see the background.

+    chrome.tabs.getAllInWindow(firstWindowId, pass(function(tabs) {
+      lastTab = tabs.pop()
+      try{

[Aaron Boodman, 2010/11/16 20:21:28]

Nit: spaces before "{":
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Conditionals

+        chrome.tabs.move(lastTab.id, {'windowId': firstWindowId, 'index': -1});
+      }
+      catch(err){ 
+      }

[Aaron Boodman, 2010/11/16 20:21:28]

Add a comment inside the catch block like:

// No need to test details of error handling here; they 
// should be tested by JSON schema tests.

+    }));
   },
 
   function remove() {