Fixes a crash when entering a negative index with chrome.tabs.move ....

chrome/test/data/extensions/api_test/tabs/basics/move.html

 <script src="tabs_util.js"></script>
 
 <script>
 var firstWindowId;
 var secondWindowId;
 var moveTabIds = {};
 
 chrome.test.runTests([
   // Do a series of moves so that we get the following
   //
@@ skipping 51 matching lines @@
         chrome.tabs.move(moveTabIds['e'], {"index": 2},
                          pass(function(tabE) {
           chrome.test.assertEq(2, tabE.index);
           chrome.tabs.move(moveTabIds['d'], {"windowId": secondWindowId,
                            "index": 2}, pass(function(tabD) {
             chrome.test.assertEq(2, tabD.index);
             checkMoveResults();
         }));
       }));
     }));
+
+    // Check that the browser doesn't segfault on a negative index

[Aaron Boodman, 2010/11/16 20:21:28]

Nit: add a period to the end of this sentence. Also, add a reference to the bug
here that we fixed so that people can see the background.

+    chrome.tabs.getAllInWindow(firstWindowId, pass(function(tabs) {
+      lastTab = tabs.pop()
+      try{

[Aaron Boodman, 2010/11/16 20:21:28]

Nit: spaces before "{":
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Conditionals

+        chrome.tabs.move(lastTab.id, {'windowId': firstWindowId, 'index': -1});
+      }
+      catch(err){ 
+      }

[Aaron Boodman, 2010/11/16 20:21:28]

Add a comment inside the catch block like:

// No need to test details of error handling here; they 
// should be tested by JSON schema tests.

+    }));
   },
 
   function remove() {
     chrome.tabs.remove(moveTabIds["d"], pass(function() {
       chrome.tabs.getAllInWindow(secondWindowId,
                                  pass(function(tabs) {
         assertEq(2, tabs.length);
         assertEq(pageUrl("b"), tabs[0].url);
         assertEq("chrome://newtab/", tabs[1].url);
       }));
     }));
   }
 ]);
 </script>