Issue 501130: Revert 34858 - Merge 34812 Add the rightclick context menu for Browser actio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501130: Revert 34858 - Merge 34812 Add the rightclick context menu for Browser actio... (Closed)

Created:
11 years ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Revert 34858 - Merge 34812 Add the rightclick context menu for Browser actions and Page Actions. BUG=29538 TEST=Rightclick an extension icon and make sure all the options work for both Page and Browser actions (Options should be grayed out when there is no Options page specified in the manifest). Review URL: http://codereview.chromium.org/486022 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/501085 TBR=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35007

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -348 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View	2 chunks	+39 lines, -2 lines	0 comments	Download
D	chrome/browser/extensions/extension_action_context_menu_model.h	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	chrome/browser/extensions/extension_action_context_menu_model.cc	View	1 chunk	+0 lines, -105 lines	0 comments	Download
M	chrome/browser/extensions/extension_disabled_infobar_delegate.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.h	View	4 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	5 chunks	+8 lines, -27 lines	0 comments	Download
D	chrome/browser/views/extensions/extension_action_context_menu.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/views/extensions/extension_action_context_menu.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	1 chunk	+4 lines, -18 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	2 chunks	+0 lines, -45 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages