Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4975)

Unified Diff: chrome/browser/views/browser_actions_container.h

Issue 501130: Revert 34858 - Merge 34812 Add the rightclick context menu for Browser actio... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_actions_container.h
===================================================================
--- chrome/browser/views/browser_actions_container.h (revision 35006)
+++ chrome/browser/views/browser_actions_container.h (working copy)
@@ -10,7 +10,6 @@
#include "base/task.h"
#include "chrome/browser/extensions/image_loading_tracker.h"
#include "chrome/browser/views/browser_bubble.h"
-#include "chrome/browser/views/extensions/extension_action_context_menu.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_registrar.h"
#include "views/controls/button/menu_button.h"
@@ -43,7 +42,7 @@
// Called to update the display to match the browser action's state.
void UpdateState();
- // Overridden from views::View. Return a 0-inset so the icon can draw all the
+ // Overriden from views::View. Return a 0-inset so the icon can draw all the
// way to the edge of the view if it wants.
virtual gfx::Insets GetInsets() const;
@@ -72,10 +71,9 @@
// Does this button's action have a popup?
virtual bool IsPopup();
- // Notifications when to set button state to pushed/not pushed (for when the
- // popup/context menu is hidden or shown by the container).
- virtual void SetButtonPushed();
- virtual void SetButtonNotPushed();
+ // Notifications when the popup is hidden or shown by the container.
+ virtual void PopupDidShow();
+ virtual void PopupDidHide();
private:
// The browser action this view represents. The ExtensionAction is not owned
@@ -90,12 +88,6 @@
// and takes care of deleting itself.
ImageLoadingTracker* tracker_;
- // The context menu for browser action icons.
- scoped_ptr<ExtensionActionContextMenu> context_menu_;
-
- // Whether we are currently showing/just finished showing a context menu.
- bool showing_context_menu_;
-
// The default icon for our browser action. This might be non-empty if the
// browser action had a value for default_icon in the manifest.
SkBitmap default_icon_;
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698