Issue 501115: Fix memory leak on ExtensionMessageBundle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501115: Fix memory leak on ExtensionMessageBundle. (Closed)

Created:
11 years ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix memory leak on ExtensionMessageBundle. Revert valgrind suppresion. BUG=30762 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34968

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	chrome/browser/renderer_host/resource_message_filter.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	chrome/common/extensions/extension_l10n_util.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM Can you also revert r34939 in this patch? We shouldn't need the Valgrind suppressions ...

11 years ago (2009-12-18 18:37:33 UTC) #2

Nebojša Ćirić

11 years ago (2009-12-18 18:54:21 UTC) #3

On 2009/12/18 18:37:33, Lei Zhang wrote:
> LGTM
> 
> Can you also revert r34939 in this patch? We shouldn't need the Valgrind
> suppressions anymore.

done (and revert)

Expand Messages | Collapse Messages