Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9976)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 501115: Fix memory leak on ExtensionMessageBundle. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_l10n_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter.cc (revision 34846)
+++ chrome/browser/renderer_host/resource_message_filter.cc (working copy)
@@ -1207,12 +1207,12 @@
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE));
std::string error;
- ExtensionMessageBundle* bundle =
+ scoped_ptr<ExtensionMessageBundle> bundle(
extension_file_util::LoadExtensionMessageBundle(
- extension_path, default_locale, &error);
+ extension_path, default_locale, &error));
std::map<std::string, std::string> dictionary_map;
- if (bundle)
+ if (bundle.get())
dictionary_map = *bundle->dictionary();
ViewHostMsg_GetExtensionMessageBundle::WriteReplyParams(
« no previous file with comments | « no previous file | chrome/common/extensions/extension_l10n_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698