Issue 501016: Merge 34534 - Mac: make it even less likely that the renderer+Breakpad leaks ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501016: Merge 34534 - Mac: make it even less likely that the renderer+Breakpad leaks ... (Closed)

Created:
11 years ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Merge 34534 - Mac: make it even less likely that the renderer+Breakpad leaks Mach ports. SuicideOnChannelErrorFilter::OnChannelError() does get called under certain (unknown) circumstances, with some regularity. This causes a leak of a Mach port when used with Breakpad. BUG=28547 TEST=See bug. Review URL: http://codereview.chromium.org/500010 TBR=viettrungluu@chromium.org,mark@chromium.org,jrg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34537

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	chrome/chrome.gyp	View		4 chunks	+1 line, -5 lines	0 comments	Download
	M	chrome/renderer/render_thread.cc	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)