Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/renderer/render_thread.cc

Issue 501016: Merge 34534 - Mac: make it even less likely that the renderer+Breakpad leaks ... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_thread.cc
===================================================================
--- chrome/renderer/render_thread.cc (revision 34536)
+++ chrome/renderer/render_thread.cc (working copy)
@@ -77,6 +77,10 @@
#include <objbase.h>
#endif
+#if defined(OS_MACOSX)
+#include "chrome/app/breakpad_mac.h"
+#endif
+
using WebKit::WebCache;
using WebKit::WebCrossOriginPreflightResultCache;
using WebKit::WebFontCache;
@@ -111,6 +115,19 @@
//
// So, we install a filter on the channel so that we can process this event
// here and kill the process.
+
+#if defined(OS_MACOSX)
+ // TODO(viettrungluu): crbug.com/28547: The following is needed, as a
+ // stopgap, to avoid leaking due to not releasing Breakpad properly.
+ // TODO(viettrungluu): Investigate why this is being called.
+ if (IsCrashReporterEnabled()) {
+ LOG(INFO) << "Cleaning up Breakpad.";
+ DestructCrashReporter();
+ } else {
+ LOG(INFO) << "Breakpad not enabled; no clean-up needed.";
+ }
+#endif // OS_MACOSX
+
_exit(0);
}
};
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698