passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot

passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot

Change-Id: I906f1959769ac9d7a2abc04827cad8f5201984de

BUG=chromeos:9168
TEST=Made sure that setting and unsetting this value and enter_chroot is honoring the pass thru setting.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e891eea

[David McMahon, 2010-11-17 00:28:36]

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh#newcode285
enter_chroot.sh:285:
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID}
${CHROOT_PASSTHRU}"
You can skip the test and default setting above and just default in-line here:
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID:-"{DEV-BUILD}"}
${CHROOT_PASSTHRU}"

[petkov, 2010-11-17 01:01:12]

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh#newcode281
enter_chroot.sh:281: #Adding OEM AU IF if it exists$
Fix the comment.

[Raja Aluri, 2010-11-17 04:12:01]

PTAL

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh#newcode281
enter_chroot.sh:281: #Adding OEM AU IF if it exists$
On 2010/11/17 01:01:12, petkov wrote:
> Fix the comment.

Done.

http://codereview.chromium.org/5008006/diff/1/enter_chroot.sh#newcode285
enter_chroot.sh:285:
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID}
${CHROOT_PASSTHRU}"
On 2010/11/17 00:28:37, David McMahon wrote:
> You can skip the test and default setting above and just default in-line here:
>
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID:-"{DEV-BUILD}"}
> ${CHROOT_PASSTHRU}"

Done.

[petkov, 2010-11-17 04:55:17]

LGTM when you address the comments and looks good to djmm@.

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh#newcode282
enter_chroot.sh:282: # Adding OEM AU APPID to CHROOT_PASSTHRU
Add a period. Or remove the comment -- kind of obvious.

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh#newcode283
enter_chroot.sh:283:
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID:-"{DEV-BUILD}"}\
This is not 80 chars. Maybe you can move the \ to right after =?

[Raja Aluri, 2010-11-17 22:58:45]

Fixed

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh#newcode282
enter_chroot.sh:282: # Adding OEM AU APPID to CHROOT_PASSTHRU
On 2010/11/17 04:55:17, petkov wrote:
> Add a period. Or remove the comment -- kind of obvious.

Done.

http://codereview.chromium.org/5008006/diff/6001/enter_chroot.sh#newcode283
enter_chroot.sh:283:
CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID:-"{DEV-BUILD}"}\
On 2010/11/17 04:55:17, petkov wrote:
> This is not 80 chars. Maybe you can move the \ to right after =?

Done.