enter_chroot.sh - Issue 5008006: passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: enter_chroot.sh

Issue 5008006: passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Patch Set: fixing code review comments Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: enter_chroot.sh

diff --git a/enter_chroot.sh b/enter_chroot.sh

index 3ca59bf9e73a9ddd63e1d0931862869f190c0ed5..c256e330377afc9d5324893c2932b23dc4eea41d 100755

--- a/enter_chroot.sh

+++ b/enter_chroot.sh

@@ -278,6 +278,11 @@ setup_env

# Use git:8 chars of sha1

REVISION=$(cd ${FLAGS_trunk}/src/scripts ; git rev-parse --short=8 HEAD)

CHROOT_PASSTHRU="CHROMEOS_REVISION=$REVISION BUILDBOT_BUILD=$FLAGS_build_number CHROMEOS_OFFICIAL=$CHROMEOS_OFFICIAL"

+# Adding OEM AU APPID to CHROOT_PASSTHRU

petkov 2010/11/17 04:55:17 Add a period. Or remove the comment -- kind of obv

Raja Aluri 2010/11/17 22:58:45 Done.

+CHROOT_PASSTHRU="CHROMEOS_RELEASE_APPID=${CHROMEOS_RELEASE_APPID:-"{DEV-BUILD}"}\

petkov 2010/11/17 04:55:17 This is not 80 chars. Maybe you can move the \ to

Raja Aluri 2010/11/17 22:58:45 Done.

+ ${CHROOT_PASSTHRU}"

if [ -d "$HOME/.subversion" ]; then

# Bind mounting .subversion into chroot

info "mounting ~/.subversion into chroot"

« no previous file with comments | « no previous file | no next file » | no next file with comments »