Chromium Code Reviews

Issue 50051: Inline the Result::Unuse member function and change the Result... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Inline the Result::Unuse member function and change the Result destructor to no longer invalidate the result. Committed: http://code.google.com/p/v8/source/detail?r=1560

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+70 lines, -30 lines)
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments
M src/codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments
M src/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments
M src/jump-target.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/jump-target-arm.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/jump-target-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/register-allocator.h View 1 chunk +2 lines, -2 lines 0 comments
src/register-allocator.cc View 2 chunks +2 lines, -10 lines 0 comments
M src/register-allocator-arm.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/register-allocator-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments
A src/register-allocator-inl.h View 1 chunk +48 lines, -0 lines 0 comments
M src/virtual-frame.cc View 1 chunk +1 line, -2 lines 0 comments
M src/virtual-frame-arm.cc View 1 chunk +1 line, -1 line 0 comments
M src/virtual-frame-ia32.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This change isn't as big as it looks, it's all in the includes. Here's a ...
11 years, 9 months ago (2009-03-20 10:31:14 UTC) #1
Erik Corry
11 years, 9 months ago (2009-03-20 12:52:59 UTC) #2
LGTM

Powered by Google App Engine