Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/profile_impl.cc

Issue 5005002: Dynamically refresh pref-configured proxies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Eric's feedback. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profile_impl.cc
diff --git a/chrome/browser/profile_impl.cc b/chrome/browser/profile_impl.cc
index 02f1a2e6bbf6f95343ee5916e3ddd2a8aba9c73c..fb9e259d40c1c23473137e4a71cd70b62cdb0f09 100644
--- a/chrome/browser/profile_impl.cc
+++ b/chrome/browser/profile_impl.cc
@@ -51,6 +51,7 @@
#include "chrome/browser/net/chrome_url_request_context.h"
#include "chrome/browser/net/gaia/token_service.h"
#include "chrome/browser/net/net_pref_observer.h"
+#include "chrome/browser/net/pref_proxy_config_service.h"
#include "chrome/browser/net/ssl_config_service_manager.h"
#include "chrome/browser/notifications/desktop_notification_service.h"
#include "chrome/browser/password_manager/password_store_default.h"
@@ -556,6 +557,9 @@ ProfileImpl::~ProfileImpl() {
if (extensions_service_)
extensions_service_->DestroyingProfile();
+ if (pref_proxy_config_tracker_)
+ pref_proxy_config_tracker_->Shutdown();
eroman 2010/11/20 03:19:07 For consistency with the callers I notice above, I
Mattias Nissler (ping if slow) 2010/11/21 22:49:14 There are others above named Shutdown, but I don't
+
// This causes the Preferences file to be written to disk.
MarkAsCleanShutdown();
}
@@ -1343,3 +1347,10 @@ chromeos::ProxyConfigServiceImpl*
return chromeos_proxy_config_service_impl_;
}
#endif // defined(OS_CHROMEOS)
+
+PrefProxyConfigTracker* ProfileImpl::GetProxyConfigTracker() {
+ if (!pref_proxy_config_tracker_)
+ pref_proxy_config_tracker_ = new PrefProxyConfigTracker(GetPrefs());
+
+ return pref_proxy_config_tracker_;
+}

Powered by Google App Engine
This is Rietveld 408576698