Dynamically refresh pref-configured proxies.

chrome/browser/profile_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 33 matching lines @@
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/host_content_settings_map.h"
 #include "chrome/browser/host_zoom_map.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/in_process_webkit/webkit_context.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/net/gaia/token_service.h"
 #include "chrome/browser/net/net_pref_observer.h"
+#include "chrome/browser/net/pref_proxy_config_service.h"
 #include "chrome/browser/net/ssl_config_service_manager.h"
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/password_manager/password_store_default.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_value_store.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
 #include "chrome/browser/profile_manager.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/search_engines/template_url_fetcher.h"
 #include "chrome/browser/search_engines/template_url_model.h"
@@ skipping 485 matching lines @@
   // FaviconService depends on HistoryServce so make sure we delete
   // HistoryService first.
   favicon_service_ = NULL;
 
   if (extension_message_service_)
     extension_message_service_->DestroyingProfile();
 
   if (extensions_service_)
     extensions_service_->DestroyingProfile();
 
+  if (pref_proxy_config_tracker_)
+    pref_proxy_config_tracker_->Shutdown();

[eroman, 2010/11/20 03:19:07]

For consistency with the callers I notice above, I suggest calling the method
DestroyingProfile(), or even DestroyingPreferenceService().

[Mattias Nissler (ping if slow), 2010/11/21 22:49:14]

There are others above named Shutdown, but I don't feel strong about this, so
changed to DestroyingPrefService().

+
   // This causes the Preferences file to be written to disk.
   MarkAsCleanShutdown();
 }
 
 ProfileId ProfileImpl::GetRuntimeId() {
   return reinterpret_cast<ProfileId>(this);
 }
 
 FilePath ProfileImpl::GetPath() {
   return path_;
@@ skipping 767 matching lines @@
 #if defined(OS_CHROMEOS)
 chromeos::ProxyConfigServiceImpl*
     ProfileImpl::GetChromeOSProxyConfigServiceImpl() {
   if (!chromeos_proxy_config_service_impl_) {
     chromeos_proxy_config_service_impl_ =
         new chromeos::ProxyConfigServiceImpl();
   }
   return chromeos_proxy_config_service_impl_;
 }
 #endif  // defined(OS_CHROMEOS)
+
+PrefProxyConfigTracker* ProfileImpl::GetProxyConfigTracker() {
+  if (!pref_proxy_config_tracker_)
+    pref_proxy_config_tracker_ = new PrefProxyConfigTracker(GetPrefs());
+
+  return pref_proxy_config_tracker_;
+}