Issue 50015: Chromium side of http://codereview.chromium.org/42394...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50015: Chromium side of http://codereview.chromium.org/42394... (Closed)

Created:
11 years, 9 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Chromium side of http://codereview.chromium.org/42394 - Remove the use of the mac specific type 'application' and use 'executable' with 'mac_bundle' set to 1. - update common.gypi to default mac_bundle to zero. - update common.gypi to look at mac_bundle for some of the base behaviors that were on 'application'. - Roll DEPS to get the new version of gyp w/ the matching support. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12136

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	build/common.gypi	View	2 chunks	+3 lines, -2 lines	1 comment	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 9 months ago (2009-03-19 17:04:53 UTC) #2

lgtm BUT
I'd like you to roll the DEPS to bring in a new GYP as part of this changelist.

http://codereview.chromium.org/50015/diff/1001/9
File build/common.gypi (right):

http://codereview.chromium.org/50015/diff/1001/9#newcode121
Line 121: ['_type=="executable" and _mac_bundle==1', {
Let's just do _mac_bundle without the ==1, since it's supposed to be a boolean.

Expand Messages | Collapse Messages