Cleanup remove mac specific type 'application'...

Remove mac specific type 'application'

- Remove knowledge from all other generators.

- Updated the xcode generator to look at the "mac_bundle" flag for xcode project
types and for adding resource bundling steps.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=375

[Mark Mentovai, 2009-03-19 17:08:54]

http://codereview.chromium.org/42394/diff/1/4
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/42394/diff/1/4#newcode479
Line 479: # w/ "+bundle" append if the target has "mac_bundle" set.
w/

http://codereview.chromium.org/42394/diff/1/4#newcode485
Line 485: # types that support being bundles
This comment (and the "basic types" one) doesn't contribute anything since
you've got the comment a few lines up that explains +bundle.

http://codereview.chromium.org/42394/diff/1/4#newcode486
Line 486: 'executable+bundle':    'com.apple.product-type.application',
Excessive space after the :

Looks like the dict values were lined up before, can you keep them lined up now?

http://codereview.chromium.org/42394/diff/1/4#newcode498
Line 498: if spec['mac_bundle']:
This should be:

if spec.get('mac_bundle', 0)

so that things work if mac_bundle is not in the spec, and it defaults to false.

http://codereview.chromium.org/42394/diff/1/4#newcode826
Line 826: if spec['mac_bundle']:
spec.get('mac_bundle', 0) again

[TVL, 2009-03-19 17:22:47]

http://codereview.chromium.org/42394/diff/1/4
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/42394/diff/1/4#newcode485
Line 485: # types that support being bundles
On 2009/03/19 17:08:54, Mark Mentovai wrote:
> This comment (and the "basic types" one) doesn't contribute anything since
> you've got the comment a few lines up that explains +bundle.

Done.

http://codereview.chromium.org/42394/diff/1/4#newcode486
Line 486: 'executable+bundle':    'com.apple.product-type.application',
On 2009/03/19 17:08:54, Mark Mentovai wrote:
> Excessive space after the :
> 
> Looks like the dict values were lined up before, can you keep them lined up
now?

Done.

http://codereview.chromium.org/42394/diff/1/4#newcode498
Line 498: if spec['mac_bundle']:
On 2009/03/19 17:08:54, Mark Mentovai wrote:
> This should be:
> 
> if spec.get('mac_bundle', 0)
> 
> so that things work if mac_bundle is not in the spec, and it defaults to
false.

Since it's defaulted in common.gypi, it's always gonna be set, i was trying to
follow what is done with mac_bundle_resources which doesn't use the get().

so switch it or keep the two in sync?

[Mark Mentovai, 2009-03-19 18:22:50]

LGTM

Fix the changelist decsription.  What's "cleanup remove?"

http://codereview.chromium.org/42394/diff/9/1021
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/42394/diff/9/1021#newcode479
Line 479: # with "+bundle" append if the target has "mac_bundle" set.
appended