Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 50005: Add a copied flag to virtual frame elements that tells if a copy has... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Add a copied flag to virtual frame elements that tells if a copy has been made of the element. Set it when copying an element, clear it when writing to an element marked copied and discovering that it is not copied. The copied flags on entry frames are exact. Preparing a frame for merging set the copied flags to be exact (to increase the likelihood of matching the entry frame or another frame). Committed: http://code.google.com/p/v8/source/detail?r=1546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -32 lines) Patch
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/jump-target.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/virtual-frame.h View 4 chunks +18 lines, -9 lines 0 comments Download
M src/virtual-frame.cc View 7 chunks +27 lines, -14 lines 0 comments Download
M src/virtual-frame-ia32.cc View 6 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-19 11:36:03 UTC) #1
William Hesse
11 years, 9 months ago (2009-03-19 11:50:20 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698