chrome/common/notification_type.h - Issue 4997001: C++ readability change for jochen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/notification_type.h

Issue 4997001: C++ readability change for jochen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/extensions

Patch Set: more long long to int64 Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/notification_type.h

diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h

index d7e6cbaff99d5804bf3c8e2f020e7e5118dd2e05..47f8beeca8d7fe21cbc92fa52b197d1be9d2c36f 100644

--- a/chrome/common/notification_type.h

+++ b/chrome/common/notification_type.h

@@ -117,12 +117,12 @@ class NotificationType {

// The DOM for a frame was fully constructed, but referenced resources

// might not be fully loaded yet. The source is a

// Source<NavigationController> corresponding to the tab in which the load

- // occurred. Details are the long long frame ID.

+ // occurred. Details are the int64 frame ID.

FRAME_DOM_CONTENT_LOADED,

// The frame finished loading. The source is a Source<NavigationController>

// corresponding to the tab in which the load occurred. Details are the

- // long long frame ID.

+ // int64 frame ID.

FRAME_DID_FINISH_LOAD,

// Content was loaded from an in-memory cache. The source will be a