Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/common/notification_type.h

Issue 4997001: C++ readability change for jochen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/extensions
Patch Set: more long long to int64 Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_NOTIFICATION_TYPE_H_ 5 #ifndef CHROME_COMMON_NOTIFICATION_TYPE_H_
6 #define CHROME_COMMON_NOTIFICATION_TYPE_H_ 6 #define CHROME_COMMON_NOTIFICATION_TYPE_H_
7 #pragma once 7 #pragma once
8 8
9 // This file describes various types used to describe and filter notifications 9 // This file describes various types used to describe and filter notifications
10 // that pass through the NotificationService. 10 // that pass through the NotificationService.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // NavigationController corresponding to the tab in which the load occurred. 110 // NavigationController corresponding to the tab in which the load occurred.
111 // Details is a ProvisionalLoadDetails object. In contrast to 111 // Details is a ProvisionalLoadDetails object. In contrast to
112 // NAV_ENTRY_COMMITTED, this notification is sent when the load was 112 // NAV_ENTRY_COMMITTED, this notification is sent when the load was
113 // committed, even if no navigation entry was committed (such as 113 // committed, even if no navigation entry was committed (such as
114 // AUTO_SUBFRAME navigations). 114 // AUTO_SUBFRAME navigations).
115 FRAME_PROVISIONAL_LOAD_COMMITTED, 115 FRAME_PROVISIONAL_LOAD_COMMITTED,
116 116
117 // The DOM for a frame was fully constructed, but referenced resources 117 // The DOM for a frame was fully constructed, but referenced resources
118 // might not be fully loaded yet. The source is a 118 // might not be fully loaded yet. The source is a
119 // Source<NavigationController> corresponding to the tab in which the load 119 // Source<NavigationController> corresponding to the tab in which the load
120 // occurred. Details are the long long frame ID. 120 // occurred. Details are the int64 frame ID.
121 FRAME_DOM_CONTENT_LOADED, 121 FRAME_DOM_CONTENT_LOADED,
122 122
123 // The frame finished loading. The source is a Source<NavigationController> 123 // The frame finished loading. The source is a Source<NavigationController>
124 // corresponding to the tab in which the load occurred. Details are the 124 // corresponding to the tab in which the load occurred. Details are the
125 // long long frame ID. 125 // int64 frame ID.
126 FRAME_DID_FINISH_LOAD, 126 FRAME_DID_FINISH_LOAD,
127 127
128 // Content was loaded from an in-memory cache. The source will be a 128 // Content was loaded from an in-memory cache. The source will be a
129 // Source<NavigationController> corresponding to the tab in which the load 129 // Source<NavigationController> corresponding to the tab in which the load
130 // occurred. Details in the form of a LoadFromMemoryCacheDetails object 130 // occurred. Details in the form of a LoadFromMemoryCacheDetails object
131 // are provided. 131 // are provided.
132 LOAD_FROM_MEMORY_CACHE, 132 LOAD_FROM_MEMORY_CACHE,
133 133
134 // A provisional content load has failed with an error. The source will be 134 // A provisional content load has failed with an error. The source will be
135 // a Source<NavigationController> corresponding to the tab in which the 135 // a Source<NavigationController> corresponding to the tab in which the
(...skipping 1174 matching lines...) Expand 10 before | Expand all | Expand 10 after
1310 }; 1310 };
1311 1311
1312 inline bool operator==(NotificationType::Type a, NotificationType b) { 1312 inline bool operator==(NotificationType::Type a, NotificationType b) {
1313 return a == b.value; 1313 return a == b.value;
1314 } 1314 }
1315 inline bool operator!=(NotificationType::Type a, NotificationType b) { 1315 inline bool operator!=(NotificationType::Type a, NotificationType b) {
1316 return a != b.value; 1316 return a != b.value;
1317 } 1317 }
1318 1318
1319 #endif // CHROME_COMMON_NOTIFICATION_TYPE_H_ 1319 #endif // CHROME_COMMON_NOTIFICATION_TYPE_H_
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698