Issue 4996003: Fix crash due to erroneous use of |controller_|....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4996003: Fix crash due to erroneous use of |controller_|.... (Closed)

Created:
10 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash due to erroneous use of |controller_|. BUG=63065 TEST=none TBR=isherman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66148

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/google/google_url_tracker.cc	View		1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

10 years, 1 month ago (2010-11-15 19:40:51 UTC) #2

LGTM, thanks

http://codereview.chromium.org/4996003/diff/1/chrome/browser/google/google_ur...
File chrome/browser/google/google_url_tracker.cc (right):

http://codereview.chromium.org/4996003/diff/1/chrome/browser/google/google_ur...
chrome/browser/google/google_url_tracker.cc:321: }
nit: Please either add braces to the other case statements or remove these

Expand Messages | Collapse Messages