Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/google/google_url_tracker.cc

Issue 4996003: Fix crash due to erroneous use of |controller_|.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_url_tracker.cc
===================================================================
--- chrome/browser/google/google_url_tracker.cc (revision 65981)
+++ chrome/browser/google/google_url_tracker.cc (working copy)
@@ -313,9 +313,12 @@
StartFetchIfDesirable();
break;
- case NotificationType::NAV_ENTRY_PENDING:
- OnNavigationPending(source, controller_->pending_entry()->url());
+ case NotificationType::NAV_ENTRY_PENDING: {
+ NavigationController* controller =
+ Source<NavigationController>(source).ptr();
+ OnNavigationPending(source, controller->pending_entry()->url());
break;
+ }
Ilya Sherman 2010/11/15 19:40:51 nit: Please either add braces to the other case st
case NotificationType::NAV_ENTRY_COMMITTED:
case NotificationType::TAB_CLOSED:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698