Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 4994004: Linux: use internal copy of libjpeg by default with mangled symbol names. (Closed)

Created:
10 years, 1 month ago by Craig
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: use internal copy of libjpeg by default with mangled symbol names. Users who want to explicitely link against the system libjpeg can just use GYP_DEFINES=use_system_libjpeg=1 when building. ChromeOS is still built against the system libjpeg. BUG=30288, 31427 TEST=compiles, trybots

Patch Set 1 #

Patch Set 2 : leave chromeos alone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/libjpeg/jpeglibmangler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Craig
This should fix the mixed libjpeg issue at the expense of using our own internal ...
10 years ago (2010-12-06 17:23:32 UTC) #1
Craig
+hbono who seems to be doing libjpeg-turbo stuff ( crbug.com/48789 ) hbono: are you planning ...
10 years ago (2010-12-07 14:54:08 UTC) #2
Craig
ping. Any comments?
10 years ago (2010-12-10 17:32:44 UTC) #3
Evan Stade
sorry for the lack of response. I'm more comfortable letting Evan Martin review this one
10 years ago (2010-12-10 21:05:15 UTC) #4
Evan Martin
I'm not clear on why we want to do this. I think we don't want ...
10 years ago (2010-12-10 21:16:44 UTC) #5
Craig
On 2010/12/10 21:16:44, Evan Martin wrote: > I'm not clear on why we want to ...
10 years ago (2010-12-11 03:34:34 UTC) #6
Evan Martin
Lei, what do you think? I reluctantly have come to think this is a good ...
10 years ago (2010-12-13 19:12:46 UTC) #7
Lei Zhang
On 2010/12/13 19:12:46, Evan Martin wrote: > Lei, what do you think? I reluctantly have ...
10 years ago (2010-12-13 20:48:18 UTC) #8
Hironori Bono
On 2010/12/13 20:48:18, Lei Zhang wrote: > I'm ok with this, but I wonder if ...
10 years ago (2010-12-14 02:37:13 UTC) #9
Craig
So should we wait for gyp issue 102 to be fixed and then use libjpeg_turbo?
10 years ago (2010-12-21 15:10:23 UTC) #10
Evan Martin
On 2010/12/21 15:10:23, Craig wrote: > So should we wait for gyp issue 102 to ...
10 years ago (2010-12-21 18:12:19 UTC) #11
Craig
On 2010/12/21 18:12:19, Evan Martin wrote: > On 2010/12/21 15:10:23, Craig wrote: > > So ...
9 years, 11 months ago (2011-01-10 16:19:01 UTC) #12
Evan Martin
On 2011/01/10 16:19:01, Craig wrote: > > In the interest of making progress on this, ...
9 years, 11 months ago (2011-01-10 17:15:49 UTC) #13
Craig
On 2011/01/10 17:15:49, Evan Martin wrote: > On 2011/01/10 16:19:01, Craig wrote: > > > ...
9 years, 11 months ago (2011-01-10 18:24:36 UTC) #14
Evan Martin
On 2011/01/10 18:24:36, Craig wrote: > Anyway, I'll cook up something that lets me test ...
9 years, 11 months ago (2011-01-10 18:29:53 UTC) #15
Craig
On 2011/01/10 18:29:53, Evan Martin wrote: > On 2011/01/10 18:24:36, Craig wrote: > > Anyway, ...
9 years, 11 months ago (2011-01-11 16:34:51 UTC) #16
Hironori Bono
Greetings Craig, Thank you for your work. If it is not so easy for you ...
9 years, 11 months ago (2011-01-12 02:11:53 UTC) #17
Craig
9 years, 10 months ago (2011-02-07 15:46:21 UTC) #18
hbono has fixed all the necessary bits for libjpeg_turbo (thanks!) and
libjpeg_turbo will probably be enabled shortly, so I'm closing this.

Powered by Google App Engine
This is Rietveld 408576698