Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 4987002: Mac: Fix for crbug.com/42517 (Closed)

Created:
10 years, 1 month ago by jeremy
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: Fix for crbug.com/42517 Detect case where Cocoa mirros BiDi chars and use the raw character value rather than the mirrored one when matching keyboard shortcuts. BUG=42517 TEST=Open several tabs, use cmd-shift-[/] shortcut to switch back and forth between them. Shortcuts should work the same in US/Hebrew and Arabic keyboard layouts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66245

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M chrome/browser/global_keyboard_shortcuts_mac.mm View 2 chunks +35 lines, -6 lines 1 comment Download
M chrome/browser/global_keyboard_shortcuts_mac_unittest.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jeremy
10 years, 1 month ago (2010-11-15 13:08:27 UTC) #1
Avi (use Gerrit)
10 years, 1 month ago (2010-11-15 15:37:39 UTC) #2
LGTM

http://codereview.chromium.org/4987002/diff/1/chrome/browser/global_keyboard_...
File chrome/browser/global_keyboard_shortcuts_mac.mm (right):

http://codereview.chromium.org/4987002/diff/1/chrome/browser/global_keyboard_...
chrome/browser/global_keyboard_shortcuts_mac.mm:164: } kMirroredBiDiChars[] = {
Can we throw a 'const' in there somewhere to make this a constant table?

Powered by Google App Engine
This is Rietveld 408576698