chrome/browser/global_keyboard_shortcuts_mac_unittest.mm - Issue 4987002: Mac: Fix for crbug.com/42517

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

Issue 4987002: Mac: Fix for crbug.com/42517 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

diff --git a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

index 4e3ab071810dc2d7f6dcdfd04d0de5f55094acc1..7db9a345d87f1a0108146c57b280334fe682f7bc 100644

--- a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

+++ b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

@@ -128,6 +128,9 @@ TEST(GlobalKeyboardShortcuts, KeyCharacterForEvent) {

// cmd-'z' / cmd-shift-';' on dvorak-qwerty

ASSERT_EQ('z', KeyCharacterForEvent(

KeyEvent(true, true, false, false, @"z", @":")));

+ // cmd-shift-'[' in an RTL context.

+ ASSERT_EQ('{', KeyCharacterForEvent(

+ KeyEvent(true, true, false, false, @"{", @"}")));

// Test if getting dead-key events return 0 and do not hang.

ASSERT_EQ(0, KeyCharacterForEvent(

KeyEvent(false, false, false, false, @"", @"")));