Issue 4987001: Implement new task manager mocks on windows.

Issue 4987001: Implement new task manager mocks on windows. (Closed)

Created:
10 years, 1 month ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Implement new task manager mocks on windows. Added API to differentiate between background resources and normal foreground tabs, and added support for grouping processes containing background resources in a separate section of task manager. BUG=63140 TEST=bring up task manager on windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66132

Patch Set 1 #

Patch Set 2 : Fixed whitespace. #

Patch Set 3 : merge with trunk #

Total comments: 10

Patch Set 4 : Updated per review feedback #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -34 lines)			Patch
M	app/table_model.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	app/table_model.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.h	View	1 2 3	4 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View	1 2 3	15 chunks	+36 lines, -22 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.h	View	1 2 3	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View		4 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/task_manager_view.cc	View	1 2	7 chunks	+55 lines, -2 lines	0 comments	Download
M	views/controls/table/group_table_view.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	views/controls/table/group_table_view.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	views/controls/table/table_view.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

git log seemed to think you'd be a reasonable choice to review this - if ...

10 years, 1 month ago (2010-11-15 02:52:13 UTC) #1

Evan Stade

lgtm http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/task_manager.cc File chrome/browser/task_manager/task_manager.cc (right): http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/task_manager.cc#newcode85 chrome/browser/task_manager/task_manager.cc:85: TaskManagerTabContentsResourceProvider* wc_provider = indent weird. why did you ...

10 years, 1 month ago (2010-11-15 03:54:00 UTC) #2

Andrew T Wilson (Slow)

10 years, 1 month ago (2010-11-15 08:20:57 UTC) #3

Thanks for the quick turnaround on this. I'll land it in the morning when I'm
around to keep an eye on the tree.

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager.cc (right):

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager.cc:85:
TaskManagerTabContentsResourceProvider* wc_provider =
On 2010/11/15 03:54:00, Evan Stade wrote:
> indent weird.
> 
> why did you move this?
The order the providers are defined also defines the order in which resources
within a given process are displayed in the task manager. I want background
pages to show up first in the list for each background process, so I moved the
BackgroundContents provider before the other providers.

I fixed the indent.

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager.cc:256: CHECK(index < ResourceCount());
On 2010/11/15 03:54:00, Evan Stade wrote:
> is there no CHECK_LT?
There is - I was just following the pattern used in other functions in this
file, but I'll change all the instances to use CHECK_LT.

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager.cc:725:
FOR_EACH_OBSERVER(TaskManagerModelObserver, observer_list_,
On 2010/11/15 03:54:00, Evan Stade wrote:
> can this all fit on one row?

Wow, it just fit. Good eye.

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager.h (right):

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager.h:107: // background (e.g. extension
background page, background contents).
On 2010/11/15 03:54:00, Evan Stade wrote:
> this comment confuses me. Can you replace "whether" with "true if" or "false
if"

Done.

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager_resource_providers.h (right):

http://codereview.chromium.org/4987001/diff/4001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager_resource_providers.h:144: std::wstring
GetTitle() const;
On 2010/11/15 03:54:00, Evan Stade wrote:
> these should be marked virtual

Done.

Expand Messages | Collapse Messages