Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2831)

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.h

Issue 4987001: Implement new task manager mocks on windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated per review feedback Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_resource_providers.h
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.h b/chrome/browser/task_manager/task_manager_resource_providers.h
index 62fbb530d79322dbaa9955c929c811cceb30ee31..9c4e8c4ce1a3af6275ee799ba4e990c66dd3bd58 100644
--- a/chrome/browser/task_manager/task_manager_resource_providers.h
+++ b/chrome/browser/task_manager/task_manager_resource_providers.h
@@ -81,9 +81,9 @@ class TaskManagerTabContentsResource : public TaskManagerRendererResource {
~TaskManagerTabContentsResource();
// TaskManager::Resource methods:
- std::wstring GetTitle() const;
- SkBitmap GetIcon() const;
- TabContents* GetTabContents() const;
+ virtual std::wstring GetTitle() const;
+ virtual SkBitmap GetIcon() const;
+ virtual TabContents* GetTabContents() const;
private:
TabContents* tab_contents_;
@@ -141,10 +141,11 @@ class TaskManagerBackgroundContentsResource
~TaskManagerBackgroundContentsResource();
// TaskManager::Resource methods:
- std::wstring GetTitle() const;
- const std::wstring& application_name() const { return application_name_; }
- SkBitmap GetIcon() const;
+ virtual std::wstring GetTitle() const;
+ virtual SkBitmap GetIcon() const;
+ virtual bool IsBackground() const;
+ const std::wstring& application_name() const { return application_name_; }
private:
BackgroundContents* background_contents_;
@@ -309,6 +310,8 @@ class TaskManagerExtensionProcessResource : public TaskManager::Resource {
// Returns the pid of the extension process.
int process_id() const { return pid_; }
+ // Returns true if the associated extension has a background page.
+ bool IsBackground() const;
private:
// The icon painted for the extension process.
static SkBitmap* default_icon_;
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | chrome/browser/task_manager/task_manager_resource_providers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698