Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4495)

Unified Diff: chrome/browser/chromeos/login/login_status_consumer.h

Issue 4980005: Allow sync with 2-factor StrongAuth accounts in ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/login_status_consumer.h
diff --git a/chrome/browser/chromeos/login/login_status_consumer.h b/chrome/browser/chromeos/login/login_status_consumer.h
index da30369996c14998da3aba4aea381de98365794a..9aa90ebdf72a52b9c52d49e5d8844de13d2b7eac 100644
--- a/chrome/browser/chromeos/login/login_status_consumer.h
+++ b/chrome/browser/chromeos/login/login_status_consumer.h
@@ -95,6 +95,10 @@ class LoginFailure {
class LoginStatusConsumer {
public:
virtual ~LoginStatusConsumer() {}
+ // Called when there was a failure during login, but the attempt may not fail
+ // (e.g. TWO_FACTOR failure). This should set any appropriate flags for
+ // consumption in OnLoginSuccess or OnLoginFailure.
+ virtual void SetLoginFailure(const LoginFailure& error) = 0;
Chris Masone 2010/11/17 01:11:09 This mechanism is kind of ugly. Why not just crea
stevenjb 2010/11/17 23:48:41 I agree that it was an awkward solution. I failed
// The current login attempt has ended in failure, with error |error|.
virtual void OnLoginFailure(const LoginFailure& error) = 0;
// The current login attempt has succeeded for
« no previous file with comments | « chrome/browser/chromeos/login/login_screen.h ('k') | chrome/browser/chromeos/login/mock_login_status_consumer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698