Allow sync with 2-factor StrongAuth accounts in ChromeOS.

chrome/browser/chromeos/login/login_status_consumer.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_STATUS_CONSUMER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_STATUS_CONSUMER_H_
 #pragma once
 
 #include <string>
 #include "chrome/common/net/gaia/gaia_auth_consumer.h"
@@ skipping 77 matching lines @@
   FailureReason reason_;
   GoogleServiceAuthError error_;
 };
 
 // An interface that defines the callbacks for objects that the
 // Authenticator class will call to report the success/failure of
 // authentication for Chromium OS.
 class LoginStatusConsumer {
  public:
   virtual ~LoginStatusConsumer() {}
+  // Called when there was a failure during login, but the attempt may not fail
+  // (e.g. TWO_FACTOR failure). This should set any appropriate flags for
+  // consumption in OnLoginSuccess or OnLoginFailure.
+  virtual void SetLoginFailure(const LoginFailure& error) = 0;

[Chris Masone, 2010/11/17 01:11:09]

This mechanism is kind of ugly.  Why not just create some kind of flag
(sync_disabled?) in GaiaAuthConsumer::ClientLoginResult that carries this
information for you, since the only time we care is in the case of a TWO_FACTOR
"failure"

[stevenjb, 2010/11/17 23:48:41]

I agree that it was an awkward solution. I failed to notice that
ClientLoginResult was a struct that I could pass this information in. Made
changes to do so which simplify the CL significantly.

   // The current login attempt has ended in failure, with error |error|.
   virtual void OnLoginFailure(const LoginFailure& error) = 0;
   // The current login attempt has succeeded for
   // |username|/|password|, returning |credentials|.  If
   // |pending_requests| is false, we're totally done.  If it's true,
   // we will still have some more results to report later.
   virtual void OnLoginSuccess(
       const std::string& username,
       const std::string& password,
       const GaiaAuthConsumer::ClientLoginResult& credentials,
       bool pending_requests) = 0;
   // The current guest login attempt has succeeded.
   virtual void OnOffTheRecordLoginSuccess() {}
   // The same password didn't work both online and offline.
   virtual void OnPasswordChangeDetected(
       const GaiaAuthConsumer::ClientLoginResult& credentials) {
     NOTREACHED();
   };
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_STATUS_CONSUMER_H_