Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 4976007: Don't allow connection to networks that are not connected.... (Closed)

Created:
10 years, 1 month ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Don't allow connection to networks that are not connected. For example, if Google-A is not configure, it will be disabled in the network menu and not selectable in the options pages. And from oobe/login, Google-A will always be disabled b/c the certificates will not be there until the user logs in. BUG=chromium-os:8293 TEST=Manual. From oobe, make sure google-a is disabled. Before setting up google-a, make sure google-a is disabled in network menu and options pages. Then set up google-a and see that it's now enabled in both network menu and options page. Log out and check that google-a is disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66356

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 5 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/internet_options_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/internet_options_handler.cc View 7 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos_internet_network_element.js View 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos_internet_options_page.css View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Charlie Lee
10 years, 1 month ago (2010-11-16 22:57:50 UTC) #1
stevenjb
On 2010/11/16 22:57:50, Charlie Lee wrote: lgtm, but you might want to have xiyuan look ...
10 years, 1 month ago (2010-11-16 23:37:51 UTC) #2
Charlie Lee
Xiyuan, can you look over the settings changes?
10 years, 1 month ago (2010-11-16 23:43:32 UTC) #3
xiyuan
http://codereview.chromium.org/4976007/diff/1/chrome/browser/resources/options/chromeos_internet_options_page.css File chrome/browser/resources/options/chromeos_internet_options_page.css (right): http://codereview.chromium.org/4976007/diff/1/chrome/browser/resources/options/chromeos_internet_options_page.css#newcode50 chrome/browser/resources/options/chromeos_internet_options_page.css:50: .network-item[connectable]:hover { What style will be used for non-connectable ...
10 years, 1 month ago (2010-11-16 23:52:17 UTC) #4
Charlie Lee
non-connectable networks won't have a hover behavior. So if you hover over it, nothing happens. ...
10 years, 1 month ago (2010-11-16 23:57:43 UTC) #5
xiyuan
10 years, 1 month ago (2010-11-17 00:01:39 UTC) #6
On 2010/11/16 23:57:43, Charlie Lee wrote:
> non-connectable networks won't have a hover behavior. So if you hover over it,
> nothing happens. And clicking on them does nothing either.
> 
Okay. LGTM then.

Powered by Google App Engine
This is Rietveld 408576698