Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: chrome/browser/chromeos/dom_ui/internet_options_handler.cc

Issue 4976007: Don't allow connection to networks that are not connected.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/dom_ui/internet_options_handler.h" 5 #include "chrome/browser/chromeos/dom_ui/internet_options_handler.h"
6 6
7 #include <ctype.h> 7 #include <ctype.h>
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 chromeos::NetworkLibrary* cros = 797 chromeos::NetworkLibrary* cros =
798 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 798 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
799 chromeos::CellularNetwork* cellular = 799 chromeos::CellularNetwork* cellular =
800 cros->FindCellularNetworkByPath(service_path); 800 cros->FindCellularNetworkByPath(service_path);
801 if (cellular) 801 if (cellular)
802 cros->RefreshCellularDataPlans(cellular); 802 cros->RefreshCellularDataPlans(cellular);
803 } 803 }
804 804
805 ListValue* InternetOptionsHandler::GetNetwork(const std::string& service_path, 805 ListValue* InternetOptionsHandler::GetNetwork(const std::string& service_path,
806 const SkBitmap& icon, const std::string& name, bool connecting, 806 const SkBitmap& icon, const std::string& name, bool connecting,
807 bool connected, chromeos::ConnectionType connection_type, bool remembered, 807 bool connected, bool connectable, chromeos::ConnectionType connection_type,
808 chromeos::ActivationState activation_state, bool restricted_ip) { 808 bool remembered, chromeos::ActivationState activation_state,
809 809 bool restricted_ip) {
810 ListValue* network = new ListValue(); 810 ListValue* network = new ListValue();
811 811
812 int connection_state = IDS_STATUSBAR_NETWORK_DEVICE_DISCONNECTED; 812 int connection_state = IDS_STATUSBAR_NETWORK_DEVICE_DISCONNECTED;
813 if (connecting) 813 if (!connectable)
814 connection_state = IDS_STATUSBAR_NETWORK_DEVICE_NOT_CONFIGURED;
815 else if (connecting)
814 connection_state = IDS_STATUSBAR_NETWORK_DEVICE_CONNECTING; 816 connection_state = IDS_STATUSBAR_NETWORK_DEVICE_CONNECTING;
815 else if (connected) 817 else if (connected)
816 connection_state = IDS_STATUSBAR_NETWORK_DEVICE_CONNECTED; 818 connection_state = IDS_STATUSBAR_NETWORK_DEVICE_CONNECTED;
817 std::string status = l10n_util::GetStringUTF8(connection_state); 819 std::string status = l10n_util::GetStringUTF8(connection_state);
818 if (connection_type == chromeos::TYPE_CELLULAR) { 820 if (connection_type == chromeos::TYPE_CELLULAR) {
819 if (activation_state == chromeos::ACTIVATION_STATE_ACTIVATED && 821 if (activation_state == chromeos::ACTIVATION_STATE_ACTIVATED &&
820 restricted_ip && connected) { 822 restricted_ip && connected) {
821 status = l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_NO_PLAN_LABEL); 823 status = l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_NO_PLAN_LABEL);
822 } else if (activation_state != chromeos::ACTIVATION_STATE_ACTIVATED) { 824 } else if (activation_state != chromeos::ACTIVATION_STATE_ACTIVATED) {
823 status.append(" / "); 825 status.append(" / ");
(...skipping 16 matching lines...) Expand all
840 // icon data url 842 // icon data url
841 network->Append(Value::CreateStringValue(icon.isNull() ? "" : 843 network->Append(Value::CreateStringValue(icon.isNull() ? "" :
842 dom_ui_util::GetImageDataUrl(icon))); 844 dom_ui_util::GetImageDataUrl(icon)));
843 // remembered 845 // remembered
844 network->Append(Value::CreateBooleanValue(remembered)); 846 network->Append(Value::CreateBooleanValue(remembered));
845 // activation_state 847 // activation_state
846 network->Append(Value::CreateIntegerValue( 848 network->Append(Value::CreateIntegerValue(
847 static_cast<int>(activation_state))); 849 static_cast<int>(activation_state)));
848 // restricted 850 // restricted
849 network->Append(Value::CreateBooleanValue(restricted_ip)); 851 network->Append(Value::CreateBooleanValue(restricted_ip));
852 // connectable
853 network->Append(Value::CreateBooleanValue(connectable));
850 return network; 854 return network;
851 } 855 }
852 856
853 ListValue* InternetOptionsHandler::GetWiredList() { 857 ListValue* InternetOptionsHandler::GetWiredList() {
854 chromeos::NetworkLibrary* cros = 858 chromeos::NetworkLibrary* cros =
855 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 859 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
856 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 860 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
857 ListValue* list = new ListValue(); 861 ListValue* list = new ListValue();
858 862
859 // If ethernet is not enabled, then don't add anything. 863 // If ethernet is not enabled, then don't add anything.
860 if (cros->ethernet_enabled()) { 864 if (cros->ethernet_enabled()) {
861 chromeos::EthernetNetwork* ethernet_network = 865 chromeos::EthernetNetwork* ethernet_network =
862 cros->ethernet_network(); 866 cros->ethernet_network();
863 SkBitmap icon = *rb.GetBitmapNamed(IDR_STATUSBAR_WIRED_BLACK); 867 SkBitmap icon = *rb.GetBitmapNamed(IDR_STATUSBAR_WIRED_BLACK);
864 if (!ethernet_network || (!ethernet_network->connecting() && 868 if (!ethernet_network || (!ethernet_network->connecting() &&
865 !ethernet_network->connected())) { 869 !ethernet_network->connected())) {
866 icon = chromeos::NetworkMenu::IconForDisplay(icon, 870 icon = chromeos::NetworkMenu::IconForDisplay(icon,
867 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_DISCONNECTED)); 871 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_DISCONNECTED));
868 } 872 }
869 if (ethernet_network) { 873 if (ethernet_network) {
870 list->Append(GetNetwork( 874 list->Append(GetNetwork(
871 ethernet_network->service_path(), 875 ethernet_network->service_path(),
872 icon, 876 icon,
873 l10n_util::GetStringUTF8(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET), 877 l10n_util::GetStringUTF8(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
874 ethernet_network->connecting(), 878 ethernet_network->connecting(),
875 ethernet_network->connected(), 879 ethernet_network->connected(),
880 ethernet_network->connectable(),
876 chromeos::TYPE_ETHERNET, 881 chromeos::TYPE_ETHERNET,
877 false, 882 false,
878 chromeos::ACTIVATION_STATE_UNKNOWN, 883 chromeos::ACTIVATION_STATE_UNKNOWN,
879 false)); 884 false));
880 } 885 }
881 } 886 }
882 return list; 887 return list;
883 } 888 }
884 889
885 ListValue* InternetOptionsHandler::GetWirelessList() { 890 ListValue* InternetOptionsHandler::GetWirelessList() {
(...skipping 10 matching lines...) Expand all
896 if ((*it)->encrypted()) { 901 if ((*it)->encrypted()) {
897 icon = chromeos::NetworkMenu::IconForDisplay(icon, 902 icon = chromeos::NetworkMenu::IconForDisplay(icon,
898 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE)); 903 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE));
899 } 904 }
900 list->Append(GetNetwork( 905 list->Append(GetNetwork(
901 (*it)->service_path(), 906 (*it)->service_path(),
902 icon, 907 icon,
903 (*it)->name(), 908 (*it)->name(),
904 (*it)->connecting(), 909 (*it)->connecting(),
905 (*it)->connected(), 910 (*it)->connected(),
911 (*it)->connectable(),
906 chromeos::TYPE_WIFI, 912 chromeos::TYPE_WIFI,
907 false, 913 false,
908 chromeos::ACTIVATION_STATE_UNKNOWN, 914 chromeos::ACTIVATION_STATE_UNKNOWN,
909 false)); 915 false));
910 } 916 }
911 917
912 const chromeos::CellularNetworkVector cellular_networks = 918 const chromeos::CellularNetworkVector cellular_networks =
913 cros->cellular_networks(); 919 cros->cellular_networks();
914 for (chromeos::CellularNetworkVector::const_iterator it = 920 for (chromeos::CellularNetworkVector::const_iterator it =
915 cellular_networks.begin(); it != cellular_networks.end(); ++it) { 921 cellular_networks.begin(); it != cellular_networks.end(); ++it) {
916 SkBitmap icon = chromeos::NetworkMenu::IconForNetworkStrength( 922 SkBitmap icon = chromeos::NetworkMenu::IconForNetworkStrength(
917 (*it)->strength(), true); 923 (*it)->strength(), true);
918 SkBitmap badge = chromeos::NetworkMenu::BadgeForNetworkTechnology(*it); 924 SkBitmap badge = chromeos::NetworkMenu::BadgeForNetworkTechnology(*it);
919 icon = chromeos::NetworkMenu::IconForDisplay(icon, badge); 925 icon = chromeos::NetworkMenu::IconForDisplay(icon, badge);
920 list->Append(GetNetwork( 926 list->Append(GetNetwork(
921 (*it)->service_path(), 927 (*it)->service_path(),
922 icon, 928 icon,
923 (*it)->name(), 929 (*it)->name(),
924 (*it)->connecting(), 930 (*it)->connecting(),
925 (*it)->connected(), 931 (*it)->connected(),
932 (*it)->connectable(),
926 chromeos::TYPE_CELLULAR, 933 chromeos::TYPE_CELLULAR,
927 false, 934 false,
928 (*it)->activation_state(), 935 (*it)->activation_state(),
929 (*it)->restricted_pool())); 936 (*it)->restricted_pool()));
930 } 937 }
931 938
932 // Add "Other..." if wifi is enabled. 939 // Add "Other..." if wifi is enabled.
933 if (cros->wifi_enabled()) { 940 if (cros->wifi_enabled()) {
934 list->Append(GetNetwork( 941 list->Append(GetNetwork(
935 kOtherNetworksFakePath, 942 kOtherNetworksFakePath,
936 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_BARS0_BLACK), 943 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_BARS0_BLACK),
937 l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_OTHER_NETWORKS), 944 l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_OTHER_NETWORKS),
938 false, 945 false,
939 false, 946 false,
947 true,
940 chromeos::TYPE_WIFI, 948 chromeos::TYPE_WIFI,
941 false, 949 false,
942 chromeos::ACTIVATION_STATE_UNKNOWN, 950 chromeos::ACTIVATION_STATE_UNKNOWN,
943 false)); 951 false));
944 } 952 }
945 953
946 return list; 954 return list;
947 } 955 }
948 956
949 ListValue* InternetOptionsHandler::GetRememberedList() { 957 ListValue* InternetOptionsHandler::GetRememberedList() {
(...skipping 10 matching lines...) Expand all
960 if ((*it)->encrypted()) { 968 if ((*it)->encrypted()) {
961 icon = chromeos::NetworkMenu::IconForDisplay(icon, 969 icon = chromeos::NetworkMenu::IconForDisplay(icon,
962 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE)); 970 *rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE));
963 } 971 }
964 list->Append(GetNetwork( 972 list->Append(GetNetwork(
965 (*it)->service_path(), 973 (*it)->service_path(),
966 icon, 974 icon,
967 (*it)->name(), 975 (*it)->name(),
968 (*it)->connecting(), 976 (*it)->connecting(),
969 (*it)->connected(), 977 (*it)->connected(),
978 true,
970 chromeos::TYPE_WIFI, 979 chromeos::TYPE_WIFI,
971 true, 980 true,
972 chromeos::ACTIVATION_STATE_UNKNOWN, 981 chromeos::ACTIVATION_STATE_UNKNOWN,
973 false)); 982 false));
974 } 983 }
975 return list; 984 return list;
976 } 985 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698