Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 495673003: Expose a pair of points for selection bound edge coordinates (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
Reviewers:
jamesr, trchen
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose a pair of points for selection bound edge coordinates Using a rect to indicate the logical selection bound edge is confusing, particular if the selection bound is not axis aligned with respect to its compositing layer. Instead, expose a top and bottom coordinate pair for the logical edge of the selection bound. The corresponding Chromium change is https://codereview.chromium.org/494823002. BUG=405666 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180773

Patch Set 1 #

Patch Set 2 : Add bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M public/platform/WebSelectionBound.h View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jdduke (slow)
trchen@: Is this what you had in mind?
6 years, 4 months ago (2014-08-20 20:20:33 UTC) #1
trchen
On 2014/08/20 20:20:33, jdduke wrote: > trchen@: Is this what you had in mind? Yes, ...
6 years, 4 months ago (2014-08-20 21:13:58 UTC) #2
jdduke (slow)
jamesr@: PTAL, the Chromium patch you reviewed (https://codereview.chromium.org/494823002/) will remove the rect reference, and trchen@ ...
6 years, 4 months ago (2014-08-21 23:48:15 UTC) #3
jamesr
lgtm
6 years, 4 months ago (2014-08-22 00:01:10 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-22 00:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/495673003/20001
6 years, 4 months ago (2014-08-22 00:57:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 01:52:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 01:55:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8170)
6 years, 4 months ago (2014-08-22 01:55:24 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-22 02:12:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/495673003/20001
6 years, 4 months ago (2014-08-22 02:13:29 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 02:15:49 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:18:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8176)
6 years, 4 months ago (2014-08-22 02:18:08 UTC) #14
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-22 12:50:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/495673003/20001
6 years, 4 months ago (2014-08-22 12:51:01 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 12:58:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180773

Powered by Google App Engine
This is Rietveld 408576698