Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 4954002: Change default minimum font size to 0 (Closed)

Created:
10 years, 1 month ago by jamesr
Modified:
9 years, 6 months ago
CC:
chromium-reviews, finnur+watch_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Change default minimum font size to 0 Chromium side of http://trac.webkit.org/changeset/72141, needed to pass Acid3. Changes the default minimum font size from 1 to 0. BUG=none TEST=acid3 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66488

Patch Set 1 #

Patch Set 2 : update the test shell prefs reset function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/resources/locale_settings_cros.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_linux.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
10 years, 1 month ago (2010-11-16 23:32:14 UTC) #1
jamesr
As far as I can tell, the value from the .grds are used in Chrome ...
10 years, 1 month ago (2010-11-16 23:33:38 UTC) #2
dglazkov1
10 years, 1 month ago (2010-11-16 23:34:49 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698