Changes to base/ from a combination of FreeBSD and OpenBSD patches.

Changes to base/ from a combination of FreeBSD and OpenBSD patches.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35321

[agl, 2009-12-14 19:31:26]

LGTM

http://codereview.chromium.org/495002/diff/1001/2003
File base/command_line.cc (right):

http://codereview.chromium.org/495002/diff/1001/2003#newcode215
base/command_line.cc:215: setproctitle("%s", title.c_str());
FreeBSD has a kernel call for setproctitle. You might want to add a comment
around here to that effect as we'll probably want to use it.

http://codereview.chromium.org/495002/diff/1001/2006
File base/file_util_posix.cc (right):

http://codereview.chromium.org/495002/diff/1001/2006#newcode88
base/file_util_posix.cc:88: #if !defined(OS_POSIX)
This is defeating the intent of the #ifdef which is to highlight this situation
for new ports. However, the line is getting a little long. Maybe it should be
removed, but we shouldn't change it to !defined(OS_POSIX)

http://codereview.chromium.org/495002/diff/1001/2006#newcode633
base/file_util_posix.cc:633: #if !defined(OS_POSIX)
Likewise.

http://codereview.chromium.org/495002/diff/1001/2016
File base/message_loop.h (right):

http://codereview.chromium.org/495002/diff/1001/2016#newcode24
base/message_loop.h:24: #if !defined(OS_MACOSX)
It might be against our style, but I would still indent this:

#  if !defined...

Feel free to ignore me if you like.