net/http/http_basic_stream.h - Issue 4935001: Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_basic_stream.h

Issue 4935001: Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove stray reference to connect_response_http_stream.h Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_basic_stream.h

===================================================================

--- net/http/http_basic_stream.h (revision 68026)

+++ net/http/http_basic_stream.h (working copy)

@@ -31,6 +31,7 @@

class HttpBasicStream : public HttpStream {

public:

HttpBasicStream(ClientSocketHandle* connection, bool using_proxy);

+ HttpBasicStream(HttpStreamParser* parser, ClientSocketHandle* connection);

vandebo (ex-Chrome) 2010/12/14 00:30:23 Maybe comments describing the different use cases

willchan no longer on Chromium 2010/12/14 00:34:42 Overloading is against the style guide. It's not

Ryan Hamilton 2010/12/15 20:14:17 Done.

Ryan Hamilton 2010/12/15 20:14:17 Sounds like a good idea, though willchan pointed o

virtual ~HttpBasicStream();

// HttpStream methods:

« net/base/net_error_list.h ('K') | « net/base/net_error_list.h ('k') | net/http/http_basic_stream.cc » ('j') | net/http/http_network_transaction.cc » ('J')