Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

net/http/http_basic_stream.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // HttpBasicStream is a simple implementation of HttpStream.  It assumes it is
 // not sharing a sharing with any other HttpStreams, therefore it just reads and
 // writes directly to the Http Stream.
 
 #ifndef NET_HTTP_HTTP_BASIC_STREAM_H_
 #define NET_HTTP_HTTP_BASIC_STREAM_H_
@@ skipping 13 matching lines @@
 class HttpResponseInfo;
 struct HttpRequestInfo;
 class HttpRequestHeaders;
 class HttpStreamParser;
 class IOBuffer;
 class UploadDataStream;
 
 class HttpBasicStream : public HttpStream {
  public:
   HttpBasicStream(ClientSocketHandle* connection, bool using_proxy);
+  HttpBasicStream(HttpStreamParser* parser, ClientSocketHandle* connection);

[vandebo (ex-Chrome), 2010/12/14 00:30:23]

Maybe comments describing the different use cases for these constructors?

[willchan no longer on Chromium, 2010/12/14 00:34:42]

Overloading is against the style guide.  It's not immediately clear what the
difference is between the two constructors.  I think you should merge them and
document them and use DCHECKs to make sure the values make sense.

[Ryan Hamilton, 2010/12/15 20:14:17]

Done.

[Ryan Hamilton, 2010/12/15 20:14:17]

Sounds like a good idea, though willchan pointed out that overloading is
verboten, so I've reworked this.

   virtual ~HttpBasicStream();
 
   // HttpStream methods:
   virtual int InitializeStream(const HttpRequestInfo* request_info,
                                const BoundNetLog& net_log,
                                CompletionCallback* callback);
 
   virtual int SendRequest(const HttpRequestHeaders& headers,
                           UploadDataStream* request_body,
                           HttpResponseInfo* response,
@@ skipping 38 matching lines @@
   std::string request_line_;
 
   const HttpRequestInfo* request_info_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpBasicStream);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_BASIC_STREAM_H_