Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2421)

Unified Diff: base/command_line_unittest.cc

Issue 4928002: Changing the installer switches from wchar_t[] to char[].... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/command_line.cc ('k') | chrome/browser/browser_main_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line_unittest.cc
===================================================================
--- base/command_line_unittest.cc (revision 65856)
+++ base/command_line_unittest.cc (working copy)
@@ -154,3 +154,17 @@
cl.command_line_string());
#endif
}
+
+// Tests that when AppendArguments is called that both the program and
+// command line strings are equal.
evanm 2010/11/14 19:15:39 Maybe change the end of this sentece to "...is cal
tommi (sloooow) - chröme 2010/11/14 21:28:07 Changed the description after incorporating Robert
+TEST(CommandLineTest, AppendArguments) {
+ CommandLine cl1(FilePath(FILE_PATH_LITERAL("Program")));
+ cl1.AppendSwitch("switch1");
+ cl1.AppendSwitchASCII("switch2", "foo");
+
+ CommandLine cl2(CommandLine::NO_PROGRAM);
+ cl2.AppendArguments(cl1, true);
evanm 2010/11/14 19:15:39 Shouldn't this hit the DCHECK(), since it's saying
evanm 2010/11/14 19:16:18 Never mind, ready it backwards. :(
+ EXPECT_EQ(cl1.command_line_string(), cl2.command_line_string());
+ EXPECT_EQ(cl1.GetProgram(), cl2.GetProgram());
+}
+
« no previous file with comments | « base/command_line.cc ('k') | chrome/browser/browser_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698