Changing the installer switches from wchar_t[] to char[]....

base/command_line_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
@@ skipping 136 matching lines @@
 #if defined(OS_WIN)
   EXPECT_EQ(L"\"Program\" "
             L"--switch1 "
             L"--switch2=value "
             L"--switch3=\"a value with spaces\" "
             L"--switch4=\"\\\"a value with quotes\\\"\" "
             L"--quotes=\"" TRICKY_QUOTED L"\"",
             cl.command_line_string());
 #endif
 }
+
+// Tests that when AppendArguments is called that both the program and
+// command line strings are equal.

[evanm, 2010/11/14 19:15:39]

Maybe change the end of this sentece to "...is called with an empty CommandLine,
nothing changes".

[tommi (sloooow) - chröme, 2010/11/14 21:28:07]

Changed the description after incorporating Robert's suggestions.

+TEST(CommandLineTest, AppendArguments) {
+  CommandLine cl1(FilePath(FILE_PATH_LITERAL("Program")));
+  cl1.AppendSwitch("switch1");
+  cl1.AppendSwitchASCII("switch2", "foo");
+
+  CommandLine cl2(CommandLine::NO_PROGRAM);
+  cl2.AppendArguments(cl1, true);

[evanm, 2010/11/14 19:15:39]

Shouldn't this hit the DCHECK(), since it's saying "include the other guy's
program", but the other guy's program is empty?

[evanm, 2010/11/14 19:16:18]

Never mind, ready it backwards.  :(

+  EXPECT_EQ(cl1.command_line_string(), cl2.command_line_string());
+  EXPECT_EQ(cl1.GetProgram(), cl2.GetProgram());
+}
+