Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 492013: fix chromeos build (Closed)

Created:
11 years ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

fix chromeos build BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34319

Patch Set 1 #

Total comments: 1

Patch Set 2 : browser_->profile() -> profile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/chromeos/main_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/main_menu.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
11 years ago (2009-12-11 01:09:30 UTC) #1
Evan Stade
http://codereview.chromium.org/492013/diff/1/2 File chrome/browser/chromeos/main_menu.cc (right): http://codereview.chromium.org/492013/diff/1/2#newcode249 chrome/browser/chromeos/main_menu.cc:249: browser_->profile()); this can probably be |profile| instead of browser_->profile()
11 years ago (2009-12-11 01:10:19 UTC) #2
oshima
On Thu, Dec 10, 2009 at 5:10 PM, <estade@chromium.org> wrote: > > http://codereview.chromium.org/492013/diff/1/2 > File ...
11 years ago (2009-12-11 01:13:17 UTC) #3
oshima
Done. Turns out this has to be profile as GetRendererPrefs can now be called before ...
11 years ago (2009-12-11 01:19:24 UTC) #4
Evan Stade
11 years ago (2009-12-11 01:26:06 UTC) #5
lgtm, thanks a lot!

Powered by Google App Engine
This is Rietveld 408576698