Stop using CHROME_BUILD altogether - companion change coming in crostools.

Stop using CHROME_BUILD altogether - companion change coming in crostools.


BUG=
TEST=

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=37f4222

[David McMahon, 2010-11-12 23:41:21]

ping.

[scottz-goog, 2010-11-12 23:51:23]

http://codereview.chromium.org/4917001/diff/1/chromeos_version.sh
File chromeos_version.sh (right):

http://codereview.chromium.org/4917001/diff/1/chromeos_version.sh#newcode88
chromeos_version.sh:88: export CHROME_VERSION="$CHROME_VERSION"
So other scripts are calling this with
CHROME_VERSION ./chromeos_version.sh? 

It seems more like the caller should be exporting CHROME_VERSION?

[scottz-goog, 2010-11-12 23:55:01]

LGTM 

since we are going to be in a better state soon I hear.

[David McMahon, 2010-11-13 00:38:06]

http://codereview.chromium.org/4917001/diff/1/chromeos_version.sh
File chromeos_version.sh (right):

http://codereview.chromium.org/4917001/diff/1/chromeos_version.sh#newcode88
chromeos_version.sh:88: export CHROME_VERSION="$CHROME_VERSION"
On 2010/11/12 23:51:23, scottz-goog wrote:
> So other scripts are calling this with
> CHROME_VERSION ./chromeos_version.sh? 
> 
> It seems more like the caller should be exporting CHROME_VERSION?

Well this is kind of a hack on a hack.  --chromebuild= was removed from
build_packages in prep for a future mechanism, so in the mean-time we need to
have some way to pass in a chrome version to build_packages (which sources
chromeos_version.sh).  In the case of a branch, CHROME_VERSION in
chromeos_version.sh gets written explicitly with the Chrome version for that
branch.  In the case of ToT, it is set in cbuild and needs to be passed down
through to the ebuild and needs to be exported.  It could be exported by the
caller (cbuild), but I'd rather keep the setting simple at the highest level and
let the build scripts handle any additional requirements (exporting) for now
until whatever future mechanism is put in place.