Stop using CHROME_BUILD altogether - companion change coming in crostools.

chromeos_version.sh

 #!/bin/sh
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # ChromeOS version information
 #
 # This file is usually sourced by other build scripts, but can be run
 # directly to see what it would do.
@@ skipping 66 matching lines @@
 fi
 
 # Version string. Not indentied to appease bash.
 export CHROMEOS_VERSION_STRING=\
 "${CHROMEOS_VERSION_MAJOR}.${CHROMEOS_VERSION_MINOR}"\
 ".${CHROMEOS_VERSION_BRANCH}.${CHROMEOS_VERSION_PATCH}"
 
 # Set CHROME values (Used for releases) to pass to chromeos-chrome-bin ebuild
 # URL to chrome archive
 export CHROME_BASE=
-# directory containing chrome-chromeos.zip - an svn rev or a full version
-export CHROME_BUILD=
-export CHROME_VERSION="$CHROME_BUILD"
+# export CHROME_VERSION from incoming value or NULL and let ebuild default
+export CHROME_VERSION="$CHROME_VERSION"

[scottz-goog, 2010/11/12 23:51:23]

So other scripts are calling this with
CHROME_VERSION ./chromeos_version.sh? 

It seems more like the caller should be exporting CHROME_VERSION?

[David McMahon, 2010/11/13 00:38:06]

Well this is kind of a hack on a hack.  --chromebuild= was removed from
build_packages in prep for a future mechanism, so in the mean-time we need to
have some way to pass in a chrome version to build_packages (which sources
chromeos_version.sh).  In the case of a branch, CHROME_VERSION in
chromeos_version.sh gets written explicitly with the Chrome version for that
branch.  In the case of ToT, it is set in cbuild and needs to be passed down
through to the ebuild and needs to be exported.  It could be exported by the
caller (cbuild), but I'd rather keep the setting simple at the highest level and
let the build scripts handle any additional requirements (exporting) for now
until whatever future mechanism is put in place.

 
 # Print (and remember) version info.
 echo "ChromeOS version information:"
 logvers="/tmp/version_${CHROMEOS_VERSION_STRING}"
 env | egrep '^CHROMEOS_VERSION|CHROME_' | tee $logvers | sed 's/^/    /'