Review request: fix 8997 -- RTL Regression: Word order separated by slash is reversed on "Bookmark M

Fix the path layout in both bookmark manager and download location. (issue 8997)
http://crbug.com/8997

Previously, the path itself and every single path component are marked with LTR marks.

The fix is only mark the path as a whole (but not every single path component)with LTR marks.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12539

[jeremy, 2009-03-25 22:06:58]

LGTM

http://codereview.chromium.org/49034/diff/1004/5
File chrome/browser/bookmarks/bookmark_table_model.cc (right):

http://codereview.chromium.org/49034/diff/1004/5#newcode336
Line 336: // LTR too.
Great comment!
Nit:perhaps add something like the following clarifying sentence at the end:
"The point here is to display the path the same way as it's displayed by other
software."

[xji, 2009-03-25 22:34:29]

On 2009/03/25 22:06:58, jeremy wrote:
> LGTM
> 
> http://codereview.chromium.org/49034/diff/1004/5
> File chrome/browser/bookmarks/bookmark_table_model.cc (right):
> 
> http://codereview.chromium.org/49034/diff/1004/5#newcode336
> Line 336: // LTR too.
> Great comment!
> Nit:perhaps add something like the following clarifying sentence at the end:
> "The point here is to display the path the same way as it's displayed by other
> software."

Done.
The comments are copied from Aharon's email. :)