Issue 49019: Make sure last_seen_time_ is protected by the CookieMonster lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49019: Make sure last_seen_time_ is protected by the CookieMonster lock. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make sure last_time_seen_ is protected by the CookieMonster lock.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	net/base/cookie_monster.cc	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Just noticed this. Not a big deal since the only reason we even have the ...

11 years, 9 months ago (2009-03-24 19:11:46 UTC) #1

darin (slow to review)

http://codereview.chromium.org/49019/diff/1/2 File net/base/cookie_monster.cc (right): http://codereview.chromium.org/49019/diff/1/2#newcode395 Line 395: creation_date = CurrentTime(); hmm... why call CurrentTime() from ...

11 years, 9 months ago (2009-03-24 19:58:24 UTC) #2

Dean McNamee

On 2009/03/24 19:58:24, darin wrote: > http://codereview.chromium.org/49019/diff/1/2 > File net/base/cookie_monster.cc (right): > > http://codereview.chromium.org/49019/diff/1/2#newcode395 > ...

11 years, 9 months ago (2009-03-24 20:33:00 UTC) #3

darin (slow to review)

11 years, 9 months ago (2009-03-24 21:04:47 UTC) #4

LGTM

Sorry, I did not read the source of CurrentTime :-P

Expand Messages | Collapse Messages