Make sure last_seen_time_ is protected by the CookieMonster lock.

net/base/cookie_monster.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 371 matching lines @@
 
 bool CookieMonster::SetCookie(const GURL& url,
                               const std::string& cookie_line) {
   CookieOptions options;
   return SetCookieWithOptions(url, cookie_line, options);
 }
 
 bool CookieMonster::SetCookieWithOptions(const GURL& url,
                                          const std::string& cookie_line,
                                          const CookieOptions& options) {
-  Time creation_date = CurrentTime();
-  last_time_seen_ = creation_date;
+  Time creation_date;
+  {
+    AutoLock autolock(lock_);
+    creation_date = CurrentTime();

[darin (slow to review), 2009/03/24 19:58:24]

hmm... why call CurrentTime() from within the lock?  if there were two threads
calling SetCookieWithOptions, it seems like it would be slightly better to let
the CurrentTime() calls happen in parallel.

+    last_time_seen_ = creation_date;
+  }
   return SetCookieWithCreationTimeWithOptions(url,
                                               cookie_line,
                                               creation_date,
                                               options);
 }
 
 bool CookieMonster::SetCookieWithCreationTime(const GURL& url,
                                               const std::string& cookie_line,
                                               const Time& creation_time) {
   CookieOptions options;
@@ skipping 707 matching lines @@
   return true;
 }
 
 std::string CookieMonster::CanonicalCookie::DebugString() const {
   return StringPrintf("name: %s value: %s path: %s creation: %llu",
                       name_.c_str(), value_.c_str(), path_.c_str(),
                       creation_date_.ToTimeT());
 }
 
 }  // namespace