Issue 487003: remove chromeos dependency from linux_view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 487003: remove chromeos dependency from linux_view (Closed)

Created:
11 years ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, not_the_right_glider, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), ben+cc_chromium.org, Ken Kania

Visibility:
Public.

Description

official build and buildbots are now chromeos=1 valgrind bots are up (they're still red tho). I believe it's ready to check this in. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35858

Patch Set 1 #

Patch Set 2 : " #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -73 lines)			Patch
M	base/base.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/views/dialog_stubs_gtk.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/chrome.gyp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	7 chunks	+49 lines, -46 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	6 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget_gtk.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages