Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: chrome/chrome_browser.gypi

Issue 487003: remove chromeos dependency from linux_view (Closed)
Patch Set: " Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 71ad68113a927e99b66d495482257a05d61e821b..9d6e5eb4636a8167d8669e4fdfb35bc0d05e1115 100755
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1847,14 +1847,7 @@
'CHROME_V8',
],
}],
- ['chromeos==1 and toolkit_views==0', {
- 'sources/': [
- ['exclude', '^browser/chromeos/browser_extenders.cc'],
- ['exclude', '^browser/gtk/external_protocol_dialog_gtk.cc'],
- ['exclude', '^browser/gtk/external_protocol_dialog_gtk.h'],
- ],
- }],
- ['chromeos==0 and toolkit_views==0', {
+ ['chromeos==0', {
'sources/': [
['exclude', '^browser/chromeos'],
],
@@ -1871,11 +1864,12 @@
'../base/base.gyp:linux_versioninfo',
],
'sources!': [
+ # Exclude extension shelf for toolstrips.
'browser/views/extensions/extension_shelf.cc',
'browser/views/extensions/extension_shelf.h',
'browser/views/extensions/extension_view.cc',
'browser/views/extensions/extension_view.h',
- # Windows-specific files.
+ # Windows-specific files.
'browser/password_manager/password_store_win.cc',
'browser/password_manager/password_store_win.h',
],
@@ -1910,13 +1904,6 @@
}],
],
}],
- ['OS=="linux" and toolkit_views==0', {
- 'sources!': [
- 'browser/bookmarks/bookmark_drop_info.cc',
- 'browser/views/autocomplete/autocomplete_popup_gtk.cc',
- 'browser/views/autocomplete/autocomplete_popup_gtk.h'
- ],
- }],
['OS=="freebsd"', {
'dependencies': [
'../build/linux/system.gyp:gtk',
@@ -2114,7 +2101,7 @@
['exclude', '^browser/views/'],
],
'conditions': [
- ['toolkit_views==1',{
+ ['OS=="linux" and (toolkit_views==1 or chromeos==1)',{
'sources/': [
['include', '^browser/dock_info_gtk.cc'],
['include', '^browser/dock_info.cc'],
@@ -2326,42 +2313,27 @@
['exclude', '^browser/browser_list_gtk.cc'],
],
}],
- ['OS=="linux" and toolkit_views==0', {
+ ['OS=="linux" and toolkit_views==1', {
+ 'sources/': [
+ ['include', '^browser/views/frame/standard_extender.h'],
+ ['include', '^browser/views/frame/standard_extender.cc'],
+ ['include', '^browser/gtk/external_protocol_dialog_gtk.cc'],
+ ['include', '^browser/gtk/external_protocol_dialog_gtk.h'],
+ ],
+ }],
+ ['OS=="linux" and chromeos==0 and toolkit_views==0', {
'sources/': [
['include', '^browser/printing/print_dialog_gtk.cc'],
['include', '^browser/printing/print_dialog_gtk.h'],
+ ['exclude', '^browser/bookmarks/bookmark_drop_info.cc'],
+ ['exclude', '^browser/views/autocomplete/autocomplete_popup_gtk.cc'],
+ ['exclude', '^browser/views/autocomplete/autocomplete_popup_gtk.h'],
],
}],
- ['chromeos==1 or toolkit_views==1',{
+ ['OS=="linux" and (chromeos==1 or toolkit_views==1)',{
'dependencies': [
- '../third_party/protobuf2/protobuf.gyp:protobuf_lite',
- '../third_party/protobuf2/protobuf.gyp:protoc#host',
- '../third_party/chromeos_login_manager/chromeos_login_manager/chromeos_login_manager.gyp:session',
- '../third_party/chromeos_login_manager/chromeos_login_manager/chromeos_login_manager.gyp:emit_login_prompt_ready',
- 'browser/chromeos/cros_api.gyp:cros_api',
'../views/views.gyp:views',
],
- 'actions': [
- {
- 'action_name': 'my_proto',
- 'inputs': [
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)protoc<(EXECUTABLE_SUFFIX)',
- 'browser/metrics/system_metrics.proto',
- ],
- 'outputs': [
- '<(INTERMEDIATE_DIR)/chrome/browser/metrics/system_metrics.pb.cc',
- '<(INTERMEDIATE_DIR)/chrome/browser/metrics/system_metrics.pb.h',
- ],
- 'dependencies': [
- '../third_party/protobuf2/protobuf.gyp:protoc',
- ],
- 'action': [
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)protoc<(EXECUTABLE_SUFFIX)',
- 'browser/metrics/system_metrics.proto',
- '--cpp_out=<(INTERMEDIATE_DIR)/chrome',
- ],
- },
- ],
'include_dirs': [
'<(INTERMEDIATE_DIR)',
'<(INTERMEDIATE_DIR)/chrome',
@@ -2405,6 +2377,37 @@
['include', 'browser/views/tabs/tab_overview_types.h'],
],
}],
+ ['OS=="linux" and chromeos==1',{
+ 'dependencies': [
+
+ '../third_party/protobuf2/protobuf.gyp:protobuf_lite',
+ '../third_party/protobuf2/protobuf.gyp:protoc#host',
+ '../third_party/chromeos_login_manager/chromeos_login_manager/chromeos_login_manager.gyp:session',
+ '../third_party/chromeos_login_manager/chromeos_login_manager/chromeos_login_manager.gyp:emit_login_prompt_ready',
+ '../third_party/cros/cros_api.gyp:cros_api',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'my_proto',
+ 'inputs': [
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)protoc<(EXECUTABLE_SUFFIX)',
+ 'browser/metrics/system_metrics.proto',
+ ],
+ 'outputs': [
+ '<(INTERMEDIATE_DIR)/chrome/browser/metrics/system_metrics.pb.cc',
+ '<(INTERMEDIATE_DIR)/chrome/browser/metrics/system_metrics.pb.h',
+ ],
+ 'dependencies': [
+ '../third_party/protobuf2/protobuf.gyp:protoc',
+ ],
+ 'action': [
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)protoc<(EXECUTABLE_SUFFIX)',
+ 'browser/metrics/system_metrics.proto',
+ '--cpp_out=<(INTERMEDIATE_DIR)/chrome',
+ ],
+ },
+ ],
+ }],
],
# Exclude files that should be excluded for all non-Windows platforms.
'sources!': [
@@ -2425,7 +2428,7 @@
],
}],
# views depends on webkit headers.
- ['OS=="win" or toolkit_views==1',{
+ ['OS=="win" or chromeos==1 or toolkit_views==1',{
'dependencies': [
'../third_party/WebKit/WebCore/WebCore.gyp/WebCore.gyp:webcore',
],
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698