If we redirect from an https to an http site, ensure that we don't...

If we redirect from an https to an http site, ensure that we don't
leak referrer information.

BUG=29920
TEST=URLRequestTestHTTP.HTTPSToHTTPRedirectNoRefererTest



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34751

[darin (slow to review), 2009-12-15 19:35:11]

http://codereview.chromium.org/486015/diff/1/2
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/486015/diff/1/2#newcode465
net/url_request/url_request.cc:465: referrer_ = "";
nit: please use referrer_.clear() instead

http://codereview.chromium.org/486015/diff/1/3
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/486015/diff/1/3#newcode323
net/url_request/url_request_unittest.cc:323:
"server-redirect?http://www.google.com"), &d);
it is very important that our network stack unit tests do not make requests to
actual servers on the internet.  doing so leads to flakiness.  instead, you
should probably use a non-HTTPS test server instance here.

[Nate Chapin, 2009-12-15 20:07:31]

On 2009/12/15 19:35:11, darin wrote:
> http://codereview.chromium.org/486015/diff/1/2
> File net/url_request/url_request.cc (right):
> 
> http://codereview.chromium.org/486015/diff/1/2#newcode465
> net/url_request/url_request.cc:465: referrer_ = "";
> nit: please use referrer_.clear() instead

Done

> 
> http://codereview.chromium.org/486015/diff/1/3
> File net/url_request/url_request_unittest.cc (right):
> 
> http://codereview.chromium.org/486015/diff/1/3#newcode323
> net/url_request/url_request_unittest.cc:323:
> "server-redirect?http://www.google.com"), &d);
> it is very important that our network stack unit tests do not make requests to
> actual servers on the internet.  doing so leads to flakiness.  instead, you
> should probably use a non-HTTPS test server instance here.

Doh, not sure how that one slipped through.  Fixed.

[darin (slow to review), 2009-12-15 21:06:16]

LGTM

http://codereview.chromium.org/486015/diff/3001/3003
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/486015/diff/3001/3003#newcode265
net/url_request/url_request_unittest.cc:265: EXPECT_EQ(std::string(""),
req.referrer());
nit: just use std::string() here.