Collect DirectX diagnostic information asynchronously....

Collect DirectX diagnostic information asynchronously.

Collecting this can take a couple of seconds. I put the code onto a worker thread. The about:gpuinfo handler polls for it until it is available, initially displaying only the subset of informtation that can be retreived quickly.

This makes the startup time for accelerated compositing, WebGL, etc significantly lower on Windows. None of the other platforms have this issue.

TEST=go to about:gpuinfo, try
BUG=59711
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66184

[Ken Russell (switch to Gerrit), 2010-11-13 02:34:45]

http://codereview.chromium.org/4860001/diff/11001/chrome/browser/browser_abou...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/4860001/diff/11001/chrome/browser/browser_abou...
chrome/browser/browser_about_handler.cc:813: }
Indentation of this block is off.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc
File chrome/gpu/gpu_thread.cc (right):

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:58: this),
This line break makes this harder to read.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:59: true)) {
CollectDxDiagnostics uses CoCreateInstance. Do we need to call CoInitialize(Ex)
on that thread? I suppose that if it weren't being called from somewhere that
the CoCreateInstance would fail.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:154: node));
thread and node could be on the previous line.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:159: const DxDiagNode& node) {
Formatting is off.

[apatrick_chromium, 2010-11-15 21:46:25]

http://codereview.chromium.org/4860001/diff/11001/chrome/browser/browser_abou...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/4860001/diff/11001/chrome/browser/browser_abou...
chrome/browser/browser_about_handler.cc:813: }
On 2010/11/13 02:34:45, kbr wrote:
> Indentation of this block is off.

Done.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc
File chrome/gpu/gpu_thread.cc (right):

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:58: this),
On 2010/11/13 02:34:45, kbr wrote:
> This line break makes this harder to read.

Done.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:59: true)) {
That's what win_util::ScopedCOMInitializer in GpuThread::CollectDxDiagnostics
does.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:154: node));
On 2010/11/13 02:34:45, kbr wrote:
> thread and node could be on the previous line.

Done.

http://codereview.chromium.org/4860001/diff/11001/chrome/gpu/gpu_thread.cc#ne...
chrome/gpu/gpu_thread.cc:159: const DxDiagNode& node) {
On 2010/11/13 02:34:45, kbr wrote:
> Formatting is off.

Done.

[Ken Russell (switch to Gerrit), 2010-11-15 22:01:31]

LGTM