Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 485008: Make building of pepper_test_plugin only happen on Linux.... (Closed)

Created:
11 years ago by sehr (please use chromium)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make building of pepper_test_plugin only happen on Windows. In the previous CL I made the build of pepper_test_plugin conditional but forgot to remove the unconditional reference, leaving the build breakage on Linux. TBR=jrg,asargent,skylined BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34232

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sehr (please use chromium)
Dear Sheriffs, My previous commit introduced a fail on Linux release that was due to ...
11 years ago (2009-12-10 04:11:19 UTC) #1
John Grabowski
LGTM but please watch the tree after this lands.
11 years ago (2009-12-10 06:35:33 UTC) #2
sehr (please use chromium)
I've been watching and there seems to be no residual problem except one possibility that ...
11 years ago (2009-12-10 09:46:20 UTC) #3
John Grabowski
11 years ago (2009-12-10 14:57:53 UTC) #4
These are "timeout 1200 sec no output" failures, yes?  Unlikely to be you.
 We saw this earlier in the day; when we ran apache by hand it yelled about
"out of space on device" when trying to grab or create a lock.  (Disk was
not full).  Reboot of bot fixed it.  Don't know how intermittent the hang
problem is or what triggers it or how new it is.

jrg

On Thu, Dec 10, 2009 at 1:46 AM, David Sehr <sehr@google.com> wrote:

> I've been watching and there seems to be no residual problem except one
> possibility that I don't quite understand: "Webkit Linux failed
> webkit_tests".  The log appears to show problems running apache.  Any
> insights?
>
>
> On Wed, Dec 9, 2009 at 10:35 PM, <jrg@chromium.org> wrote:
>
>> LGTM but please watch the tree after this lands.
>>
>>
>>
>> http://codereview.chromium.org/485008
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698